Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes bugs in the CLI and codegen components while improving package name handling and consolidating code generation logic. Key changes include:
- Updating functions to accept an optional package parameter and using it to determine the default package name.
- Refactoring the codegen module to differentiate common and specialized generators and cleaning up duplicate implementations.
- Adjusting CLI options (help texts and flags) and updating related documentation and changelogs.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/dipdup/project.py | Updated get_default_answers and answers_from_terminal to accept a package param. |
| src/dipdup/dipdup.py | Rearranged initialization logic and added conditional logic for full init. |
| src/dipdup/context.py | Minor reordering of import statements. |
| src/dipdup/codegen/init.py | Refactored abstract methods and merged duplicate code into common generator class. |
| src/dipdup/cli.py | Revised CLI option texts and added new project name option. |
| pyproject.toml | Pinned dependency version with a comment fix. |
| docs/* | Updated release notes, CLI references, and changelog entries. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.