Skip to content

Comments

8.4 release notes, http URL and config fixes#1259

Merged
droserasprout merged 6 commits intonextfrom
aux/last-8.4-bits
May 21, 2025
Merged

8.4 release notes, http URL and config fixes#1259
droserasprout merged 6 commits intonextfrom
aux/last-8.4-bits

Conversation

@droserasprout
Copy link
Collaborator

No description provided.

@droserasprout droserasprout added this to the 8.4.0 milestone May 20, 2025
@droserasprout droserasprout requested a review from Wizard1209 May 20, 2025 18:27
@droserasprout droserasprout added bug Something isn't working documentation Improvements or additions to documentation labels May 20, 2025
@droserasprout droserasprout requested a review from Copilot May 20, 2025 18:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces several fixes and improvements for release 8.4 focusing on updating configuration for the watchdog service, adjusting HTTP URL handling in datasources, and updating documentation and release notes accordingly.

  • Refactored watchdog initialization to use a new WatchdogConfig.
  • Adjusted HTTP endpoint URL assembly in the Subsquid datasource.
  • Updated documentation, changelog, and command line flags to reflect the changes.

Reviewed Changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/dipdup/dipdup.py Simplified watchdog configuration initialization.
src/dipdup/datasources/_subsquid.py Modified URL formation for worker endpoint.
src/dipdup/config/init.py Updated watchdog field type to use WatchdogConfig.
schemas/dipdup-3.0.json Revised JSON schema to reference WatchdogConfig.
docs/config.rst Added documentation for the new WatchdogConfig.
docs/9.release-notes/6.v7.5.md Updated migration guide link for branch v7.0.
docs/9.release-notes/1.v8.4.md Added release notes for version 8.4.
docs/7.references/2.config.md Expanded reference documentation to include WatchdogConfig.
docs/5.advanced/6.sqd-cloud.md Updated command flag for the squad cloud deployment.
docs/5.advanced/2.environment-variables.md Adjusted text for enabling debug mode.
CHANGELOG.md Updated release date and noted an HTTP URL merge fix.
Comments suppressed due to low confidence (3)

src/dipdup/dipdup.py:976

  • The new watchdog initialization bypasses the previous merging of default configurations. Confirm that this simplified approach fully replicates the intended behavior for legacy configurations.
watchdog.initialize(self._ctx.config.advanced.watchdog)

src/dipdup/datasources/_subsquid.py:115

  • Removing the base URL (self._config.url) from the worker endpoint may lead to incorrect URL formation. Verify that the base URL is concatenated elsewhere or that this change is intentional.
f'{level}/worker'

docs/5.advanced/6.sqd-cloud.md:34

  • The command now uses the '-C' flag for specifying the config; ensure that related documentation and usage examples are updated to reflect this new behavior.
cmd: ["dipdup", "-C", "squid-cloud", "run"]

@droserasprout droserasprout merged commit a130019 into next May 21, 2025
6 checks passed
@droserasprout droserasprout deleted the aux/last-8.4-bits branch May 21, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants