8.4 release notes, http URL and config fixes#1259
Merged
droserasprout merged 6 commits intonextfrom May 21, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces several fixes and improvements for release 8.4 focusing on updating configuration for the watchdog service, adjusting HTTP URL handling in datasources, and updating documentation and release notes accordingly.
- Refactored watchdog initialization to use a new WatchdogConfig.
- Adjusted HTTP endpoint URL assembly in the Subsquid datasource.
- Updated documentation, changelog, and command line flags to reflect the changes.
Reviewed Changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/dipdup/dipdup.py | Simplified watchdog configuration initialization. |
| src/dipdup/datasources/_subsquid.py | Modified URL formation for worker endpoint. |
| src/dipdup/config/init.py | Updated watchdog field type to use WatchdogConfig. |
| schemas/dipdup-3.0.json | Revised JSON schema to reference WatchdogConfig. |
| docs/config.rst | Added documentation for the new WatchdogConfig. |
| docs/9.release-notes/6.v7.5.md | Updated migration guide link for branch v7.0. |
| docs/9.release-notes/1.v8.4.md | Added release notes for version 8.4. |
| docs/7.references/2.config.md | Expanded reference documentation to include WatchdogConfig. |
| docs/5.advanced/6.sqd-cloud.md | Updated command flag for the squad cloud deployment. |
| docs/5.advanced/2.environment-variables.md | Adjusted text for enabling debug mode. |
| CHANGELOG.md | Updated release date and noted an HTTP URL merge fix. |
Comments suppressed due to low confidence (3)
src/dipdup/dipdup.py:976
- The new watchdog initialization bypasses the previous merging of default configurations. Confirm that this simplified approach fully replicates the intended behavior for legacy configurations.
watchdog.initialize(self._ctx.config.advanced.watchdog)
src/dipdup/datasources/_subsquid.py:115
- Removing the base URL (self._config.url) from the worker endpoint may lead to incorrect URL formation. Verify that the base URL is concatenated elsewhere or that this change is intentional.
f'{level}/worker'
docs/5.advanced/6.sqd-cloud.md:34
- The command now uses the '-C' flag for specifying the config; ensure that related documentation and usage examples are updated to reflect this new behavior.
cmd: ["dipdup", "-C", "squid-cloud", "run"]
Wizard1209
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.