Conversation
✅ Deploy Preview for directus-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds PostHog A/B testing capabilities to button groups, allowing for experimentation with different header button configurations. The implementation extends the existing button group functionality to support experiment variants that can be dynamically selected based on PostHog feature flags.
- Adds experiment-related fields to button group schemas and types
- Implements A/B testing logic in the ButtonGroup component using PostHog feature flags
- Updates the header component to support the new experiment-enabled button groups
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| types/schema/schema.ts | Adds HeaderButtonVariant type import and schema definition |
| types/schema/meta/globals.ts | Defines HeaderButtonVariant interface and adds it to Globals |
| types/schema/blocks/block-button-group.ts | Extends BlockButtonGroup with experiment fields and adds ButtonGroupWithExperiment interface |
| components/Nav/Header.vue | Updates data fetching variable names for consistency |
| components/Block/ButtonGroup.vue | Implements A/B testing logic using PostHog feature flags |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add posthog AB testing to Button Groups
Works with flow [PostHog] Create Variants to set up button groups with a posthog experiement and create variants