Conversation
✅ Deploy Preview for directus-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes A/B testing for Posthog by correcting how feature flag payloads are processed in the experiments middleware. The previous implementation incorrectly used Object.values() which returned only the payload values, but the code was trying to iterate over them as if they were the full payload objects.
Key changes:
- Updated type from
Record<string, boolean | string>toRecord<string, JsonType>to match the actual payload structure - Changed from
Object.values()toObject.entries()to properly iterate over the flag name/payload pairs - Fixed the logic to access payload properties correctly using
Object.entries()which provides both the flag name and payload object
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MattatDirectus
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤞 hope this does the trick