Conversation
✅ Deploy Preview for directus-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates PostHog packages from versions 1.260.1/5.7.0 to 1.314.0/5.19.0 to fix AB testing functionality. The main code change adds a call to getFeatureFlag() in the experiments middleware to ensure feature flags are properly evaluated during page-type experiments.
Key Changes:
- Updated
posthog-jsfrom 1.260.1 to 1.314.0 - Updated
posthog-nodefrom 5.7.0 to 5.19.0 - Modified experiment middleware to call
getFeatureFlag()before checking redirect conditions
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Updated PostHog client and server packages to newer versions |
| pnpm-lock.yaml | Lockfile updates reflecting PostHog version changes and transitive dependencies |
| middleware/experiments.global.ts | Added getFeatureFlag() call and restructured logic to ensure flag evaluation occurs before redirect |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MattatDirectus
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the AB testing but for real this time...