DEV: Refactor plugin to remove deprecated Ember decorators#140
Merged
DEV: Refactor plugin to remove deprecated Ember decorators#140
Conversation
Replaced the use of deprecated Ember decorators like `@readOnly` and `@computed` with native getter methods to modernize the codebase. Updated the `#channel` property to utilize native class field syntax for improved clarity and maintainability. This change prepares the plugin for future updates and aligns it with best practices in modern Ember.js development. Existing functionality remains unaffected.
davidtaylorhq
approved these changes
Oct 14, 2025
Added compatibility entry for `< 3.6.0.beta2-latest` in the `whos-online` plugin to reflect changes in supported Discourse versions. This ensures accurate version checks and maintains plugin stability across updates.
megothss
changed the title
whos-online plugin to remove legacy Ember decorators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced the use of deprecated Ember decorators like
@readOnlyand@computedwith native getter methods to modernize the codebase. Updated the#channelproperty to utilize native class field syntax for improved clarity and maintainability.This change prepares the plugin for future updates and aligns it with best practices in modern Ember.js development. Existing functionality remains unaffected.