Conversation
| awsEnv: AwsEnvironment[F] | ||
| ): service.Impl[F] = | ||
| ): service.Impl[F] = { | ||
| implicit val hashingF: Hashing[F] = Hashing.forSync[F] |
There was a problem hiding this comment.
didn't bother passing it from the outside and doing a deprecation on this build signature, but I'm open to suggestions
| } | ||
| }, | ||
| "400": { | ||
| "description": "FallbackError 400 response", |
There was a problem hiding this comment.
consequence of disneystreaming/alloy#204 , I suppose
| object project { | ||
| def genericClientError: Option[GenericClientError] = GetMenuError.GenericClientErrorCase.alt.project.lift(self).map(_.genericClientError) | ||
| def fallbackError2: Option[FallbackError2] = GetMenuError.FallbackError2Case.alt.project.lift(self).map(_.fallbackError2) | ||
| def fallbackError: Option[FallbackError] = GetMenuError.FallbackErrorCase.alt.project.lift(self).map(_.fallbackError) | ||
| def notFoundError: Option[NotFoundError] = GetMenuError.NotFoundErrorCase.alt.project.lift(self).map(_.notFoundError) | ||
| def fallbackError: Option[FallbackError] = GetMenuError.FallbackErrorCase.alt.project.lift(self).map(_.fallbackError) | ||
| def fallbackError2: Option[FallbackError2] = GetMenuError.FallbackError2Case.alt.project.lift(self).map(_.fallbackError2) | ||
| def genericClientError: Option[GenericClientError] = GetMenuError.GenericClientErrorCase.alt.project.lift(self).map(_.genericClientError) | ||
| } |
There was a problem hiding this comment.
not sure which change triggered this reordering. smithy-lang/smithy#2513 looks related, but it's in the IDL serializer, and resource-specific. I checked the changelog for "sort" and "order" and "properties" but nothing else stood out.
still, this is the order as in the spec.
kubukoz
force-pushed
the
update-deps-2025-04
branch
from
d5a0eaa to
3b9bfa0
Compare
| "RestXmlHttpPayloadWithUnsetUnion" | ||
| "RestXmlHttpPayloadWithUnsetUnion", | ||
|
|
||
| // TODO same as above, added between 1.49 and 1.56. Mostly default-related |
There was a problem hiding this comment.
on a good note, the FieldFilter functionality might help us fix these more quickly.
|
@Baccata fyi this AT LEAST passes the tests on 2.13 locally, with a snapshot of disneystreaming/aws-sdk-smithy-specs#16 the idea for the next step is as follows:
you cool with that or should I make this use the Sonatype snapshot? (which doesn't have publishing set up yet) |
lewisjkl
left a comment
lewisjkl
left a comment
There was a problem hiding this comment.
This all looks good to me, thanks for going through all of this, much better to have it all up to date.
|
My hand was forced by an upcoming Alloy update in #1677 :) |
3 participants
PR Checklist (not all items are relevant to all PRs)