Open
Conversation
AshCorr
commented
Jan 15, 2025
Comment on lines
+487
to
+493
| /** | ||
| * Add a cookie based on its name, if it does not exist yet. Cookies that | ||
| * are already set will be ignored. | ||
| */ | ||
| def addCookieIfUnset(cookie: Cookie) = { | ||
| subject.underlying(_.addCookieIfUnset(cookie)) | ||
| } |
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AHC 3.0.1 has a Critical CVE which is causing downstream consumers of dispatch to get vulnerability alerts.
Included in 3.0.1 are a few dependency upgrades in addition to the fix for the CVE. AHC considers 3.0.1 as breaking release as they've added a new method to the abstract RequestBuilderBase class.
Worth noting that the behaviour of the default client has changed slightly in order to fix the CVE. Previously cookies found in the cookie jar would replace cookies in the RequestBuilder, this is no longer the case.
Not quite sure about the branch layout of this repo! Should this change go to the
2.0.xbranch?