Merged
Conversation
FarhanAliRaza
changed the title
* Updated _handle_generic_exception method to accept an optional request parameter for improved error reporting. * Modified generic_exception_handler to utilize Django's ExceptionReporter for HTML output in debug mode, falling back to JSON if necessary. * Added tests to verify the behavior of the generic exception handler in debug mode, ensuring correct HTML response formatting.
* Updated BENCHMARK_BASELINE.md and BENCHMARK_DEV.md with new performance metrics reflecting changes in request rates and response times across various endpoints. * Adjusted Makefile to reduce the number of processes from 8 to 4 for benchmarking. * Enhanced logging middleware and configuration to support non-blocking logging and improved log level management based on response status and sampling. * Refined logging setup in Django settings to differentiate between development and production environments, ensuring appropriate log levels are applied.
* Updated BENCHMARK_BASELINE.md and BENCHMARK_DEV.md with new performance metrics reflecting changes in request rates and response times across various endpoints, including significant improvements in the root endpoint and other key routes. * Adjusted Makefile to increase the number of processes from 4 to 8 for benchmarking. * Enhanced logging middleware to ensure proper cleanup of queue listeners and improved exception handling during logging setup. * Refined logging configuration in Django settings to ensure appropriate log levels are applied in production environments.
* Updated test cases to ensure the generic exception handler returns HTML in debug mode and handles requests correctly. * Added tests for scenarios without a request context and for fallback to JSON when HTML generation fails. * Improved assertions to provide clearer error messages for debugging purposes. * Verified that exception tracebacks are preserved and formatted correctly in both HTML and JSON responses.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.