feat(talks): add 3D Earth globe for Djangonaut talks worldwide#640
feat(talks): add 3D Earth globe for Djangonaut talks worldwide#640
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #640 +/- ##
========================================
Coverage 94.80% 94.80%
========================================
Files 162 162
Lines 7156 7156
Branches 238 238
========================================
Hits 6784 6784
Misses 331 331
Partials 41 41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This PR also fixes the playwright test issue reported here |
tim-schilling
left a comment
tim-schilling
left a comment
There was a problem hiding this comment.
Thank you for doing this @Mitchina! This is going to be great to have. I have a few pointers on how to structure the changes, but it largely seems solid. I do think we'll want to add some tests to the application for this. We'd want to confirm the API works as expected and that the page works. Since we don't have a JS testing utility, I've been using playwright to test those changes.
|
Hi @tim-schilling! Thanks so much for the detailed review and taking the time to go through this! Really appreciate it. I've extracted the timezone fix into its own PR for quick merge 😊 For your other suggestions in the comments, I'm planning to address them this next weekend if I feel better, I got a cold and feeling a bit under the weather right now. For Playwright tests, I can definitely give those a try, but others with more experience might be faster. Happy if someone else wants to jump in on that too! Thanks again! |
for more information, see https://pre-commit.ci
… feature/3d-earth-talks-map
|
Hi @tim-schilling! Thanks again for the thorough review. I finally managed to find the time to address all your comments from the previous feedback (the PR has so many lines added because we've pulled the three module files asked here: #640 (comment) into the repo). I've also added all the tests, plus one Playwright test, please let me know what do you think! Note: my building is failing again because of that Playwright test that checks the timezone (the one not related to the map changes), and the timezone in the CI is different again of the expected (locally I have every test passing): |
| @@ -0,0 +1,70 @@ | |||
| # Post-Map Page Setup (For Existing DB Users) | |||
There was a problem hiding this comment.
I'm a bit confused by the purpose of this file. Can you help me understand it please?
| migrations.RunSQL( | ||
| "CREATE EXTENSION IF NOT EXISTS postgis;", | ||
| reverse_sql=migrations.RunSQL.noop, # Does nothing when rolled back | ||
| ), |
There was a problem hiding this comment.
This can be replaced with django.contrib.postgres.operations.CreateExtension if you'd like:
CreateExtension("postgis"),| def get_popup_html(self, obj): | ||
| video_html = ( | ||
| f""" | ||
| <a href="${obj.video_link}" target="_blank" aria-label="Watch talk recording"> |
There was a problem hiding this comment.
| <a href="${obj.video_link}" target="_blank" aria-label="Watch talk recording"> | |
| <a href="{obj.video_link}" target="_blank" aria-label="Watch talk recording"> |
I think there's an errant character in this?
| markers = globe_page.locator("#markerPopup") | ||
| # Markers will be present in the DOM but hidden | ||
| expect(markers).to_be_attached() | ||
| expect(markers).to_be_hidden() |
There was a problem hiding this comment.
Is it possible to confirm that clicking on a marker causes the extra panel to appear?
There was a problem hiding this comment.
I'll likely swap these out for their minified versions. If you want to do that, that's great, but I'm happy to do that as we get closer to merging.
tim-schilling
left a comment
tim-schilling
left a comment
There was a problem hiding this comment.
This is coming along really nicely! I have a few more changes and suggestions.
I've merged a change which should help us diagnose that in the future. For now if you see an error with that timezone comparison, please ignore it. |
2 participants
This PR adds a 3D Earth Talks Map Feature.
A new page was added with a Three.js globe showcasing Djangonaut Space member presentations worldwide with geo-located purple spike markers and popups.
Features
New Dependencies:
Stack Additions:
Documentation:
docs/post-map-changes.md- PostGIS setup for existing DBsREADME.md- Map setup instructions.claude/CLAUDE.md- Talks app structureThis PR also closes #625 (the playwright test issue)