Run the playwright tests against multiple browsers.#689
Open
tim-schilling wants to merge 3 commits intodevelopfrom
Open
Run the playwright tests against multiple browsers.#689tim-schilling wants to merge 3 commits intodevelopfrom
tim-schilling wants to merge 3 commits intodevelopfrom
Conversation
drag_to() uses HTML5 drag events (dragstart/dragover/drop), but Viselect listens for mousedown/mousemove/mouseup. This didn't work in WebKit, and was also flaky in other browsers. Replace drag_to() with a drag_select() helper that uses explicit mouse events: - scroll_into_view_if_needed() to ensure elements are visible - Start at the top edge / end at the bottom edge of cells for full coverage of the selection rectangle - Wait for the last cell to have the `selecting` class (the visual preview viselect applies during a drag) before releasing the mouse, confirming viselect has fully processed the selection Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The onboarding flow test had the same drag_to() issue as the availability test — Viselect listens for mousedown/mousemove/mouseup, not HTML5 drag events. Moved drag_select() to conftest.py so both test files share it, and replaced the drag_to + wait_for_timeout call in set_availability(). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
tim-schilling
force-pushed
the
test-multiple-browsers
branch
from
7426a6d to
824e530
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also adjusts the playwright tests around using the
drag_select. Webkit doesn't support that event, so a more basic approach was necessary.