Conversation
Sub-allocate each particle slab with the content of multiple effects. - Introduce a `base_particle` value per effect instance, which is the equivalent of the `base_vertex` for rendering, and corresponds to the index of the first particle in the sub-allocated slice for that effect, inside the overall slab buffer. - Store that `base_particle` in the `Spawner` and give access to all shaders which need it (most of them). - Restore the default 64k particle count per slab, which allows packing multiple effects per buffer/slab. When `debug_assertions` is active (in Debug build), fill the first value of each particle to a `NaN` (0xFFFFFFFF) to make it easier to see in RenderDoc or any other GPU debugger that the particle is unused.
djeedai
added
C - enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sub-allocate each particle slab with the content of multiple effects.
base_particlevalue per effect instance, which is the equivalent of thebase_vertexfor rendering, and corresponds to the index of the first particle in the sub-allocated slice for that effect, inside the overall slab buffer.base_particlein theSpawnerand give access to all shaders which need it (most of them).When
debug_assertionsis active (in Debug build), fill the first value of each particle to aNaN(0xFFFFFFFF) to make it easier to see in RenderDoc or any other GPU debugger that the particle is unused.