Address all formatting warnings from linters#11977
Address all formatting warnings from linters#11977hcho3 wants to merge 9 commits intodmlc:masterfrom
Conversation
|
Oh ... |
| exclude: (dmlc-core|gputreeshap|demo\/c-api|jvm-packages\/xgboost4j\/src\/native\/xgboost4j\..*) | ||
| additional_dependencies: | ||
| - cpplint==1.6.1 | ||
| - cpplint |
There was a problem hiding this comment.
Note: JNI files and C API demos have been excluded from cpplint checks.
| @@ -68,7 +68,15 @@ def __init__(self) -> None: | |||
| ",".join( | |||
There was a problem hiding this comment.
Note: Some checks in cpplint have been turned off.
|
Turning this to draft for now. I didn't realize that #11953 would uncover this many formatting issues ... |
|
TODOs
|
|
I suggest we fix the headers first using #11790
|
|
Lets not do it this way :) I didn't intend anyone to run The main problem I see right now is that we are running one of our python lint scripts in pre-commit which touches every file - it should be split into its component tools in the pre-commit script and run only on changed files. |
I used the AI assistance to resolve many of the cpplint warnings.
Tips for the reviewer: Make sure to hide whitespaces when reviewing.I will split this PR into smaller PRs, oncepre-commit run --all-filespasses without any warning.