Skip to content

Conversation

@krissetto
Copy link
Contributor

Give it a try and let me know if this is worth a cleanup pass

⚠️ Ignore the code for now, plenty of vibes and it has not been thoroughly looked into.

  • Makes the sidebar agents section its own component (as an example for future refactoring of all sections)
  • Cleans up agent view in the sidebar to only show essential agent info (name and model)
  • Allows switching by clicking on the agent in the sidebar
  • Adds proper agent selection dialog with more info per agent and easier to read descriptions, including expandable toolset/tool list

Screencast

Screencast.From.2026-02-01.21-54-38.mp4

@krissetto krissetto changed the title Cleaner agent switching and rendering in the TUI Cleaner agent switching ux in the TUI Feb 1, 2026
@krissetto
Copy link
Contributor Author

/review

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Summary

Found 1 high-severity issue in the new toolset unwrapping logic that could cause a nil pointer panic.

Issues Found

  • HIGH: Nil pointer dereference risk in getToolsetDisplayName function

What Looks Good

  • Context cancellation properly handled in background goroutine
  • Mutex protection correctly implemented for cache access
  • Click handling and bounds checking are solid
  • Agent picker dialog implementation looks safe

@krissetto krissetto self-assigned this Feb 3, 2026
@krissetto krissetto force-pushed the better-agent-view-tui branch from 257f54d to 23a97a0 Compare February 4, 2026 13:09
Signed-off-by: Christopher Petito <chrisjpetito@gmail.com>
@krissetto krissetto force-pushed the better-agent-view-tui branch from 23a97a0 to 9e7ad33 Compare February 4, 2026 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant