Skip to content

Conversation

@derekmisler
Copy link
Contributor

@derekmisler derekmisler commented Feb 4, 2026

Summary

Simplifies the PR review workflow by adopting the new reusable workflow from cagent-action. This reduces ~100 lines of duplicated logic to a single workflow call.

Changes

  • .github/workflows/pr-review.yml: Replace inline job definitions with reusable workflow reference

How to Test

  • Open a new PR (auto-review triggers for Docker org members)
  • Alternatively, comment /review on any PR
  • Reply to a review comment (learn-from-feedback still works)

@derekmisler derekmisler self-assigned this Feb 4, 2026
@derekmisler
Copy link
Contributor Author

Once I've made a new release of cagent-action with these changes, I'll mark this one as ready for review.

@derekmisler
Copy link
Contributor Author

/review

@derekmisler derekmisler force-pushed the cagent-action-workflow-with-github-app-built-in branch from 44580a2 to 5473922 Compare February 4, 2026 18:36
github-actions[bot]

This comment was marked as outdated.

@derekmisler derekmisler force-pushed the cagent-action-workflow-with-github-app-built-in branch from ca9873b to 9a0459b Compare February 4, 2026 18:39
@derekmisler derekmisler dismissed github-actions[bot]’s stale review February 4, 2026 18:40

outdated (i was just testing)

@derekmisler derekmisler marked this pull request as ready for review February 4, 2026 18:41
@derekmisler derekmisler requested a review from a team as a code owner February 4, 2026 18:41
github-actions[bot]
github-actions bot previously approved these changes Feb 4, 2026
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Review Complete

No issues found in the changed code. The refactoring correctly uses the reusable workflow syntax:

  • uses: docker/cagent-action/.github/workflows/review-pr.yml@latest is the proper format for calling a reusable workflow
  • secrets: inherit correctly passes all secrets from the caller workflow to the reusable workflow
  • The workflow triggers and permissions remain unchanged, so behavior should be preserved

The simplification from ~100 lines to a single workflow call is a good improvement for maintainability. The reusable workflow in docker/cagent-action should handle all the logic that was previously inline.

@derekmisler
Copy link
Contributor Author

/review

@derekmisler derekmisler dismissed github-actions[bot]’s stale review February 4, 2026 19:10

outdated (just testing)

@derekmisler derekmisler marked this pull request as draft February 4, 2026 19:11
@derekmisler derekmisler marked this pull request as ready for review February 4, 2026 19:11
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

No issues found - The code changes look good!

This PR successfully simplifies the workflow by adopting a reusable workflow pattern. The removal of inline conditional logic is intentional and follows GitHub Actions best practices - the reusable workflow receives full event context and can handle the different trigger scenarios internally.

The architectural change from ~100 lines of duplicated logic to a single reusable workflow call improves maintainability while preserving functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant