Fix: Remove inconsistent human readability warning from docker images#6754
Open
MaheshThakur9152 wants to merge 1 commit intodocker:masterfrom
Open
Fix: Remove inconsistent human readability warning from docker images#6754MaheshThakur9152 wants to merge 1 commit intodocker:masterfrom
MaheshThakur9152 wants to merge 1 commit intodocker:masterfrom
Conversation
Signed-off-by: Mahesh Thakur <maheshthakur9152@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
docker imagesoutput is redirected (non-TTY). This involved removing the logic intree.goand the unusedstreamRedirectedhelper function.list.go(in the "ambiguous argument" hint).Why I did it
docker imageswas the only list command (unlikedocker ps,docker volume ls, etc.) to emit this warning when piped. This change aligns behavior across the CLI.docker images | grep ...) and complicates parsing for users who have relied on this behavior for years.How I verified it
TestPrintImageTreeNoWarningWhenRedirectedintree_test.goto ensure no warning is emitted on redirection.list-command-ambiguous.goldento match the cleaner output (verified that the leading blank line is gone).dev-containerenvironment.Related Issue
Closes #6749