Add package.json's for yarn > v1 support#80
Open
vespakoen wants to merge 1 commit intodocsforadobe:masterfrom
Open
Add package.json's for yarn > v1 support#80vespakoen wants to merge 1 commit intodocsforadobe:masterfrom
vespakoen wants to merge 1 commit intodocsforadobe:masterfrom
Conversation
e98bb94 to
052bc32
Compare
Member
|
@vespakoen Is this still needed / a useful change? |
Contributor
Author
|
I am not doing CEP development anymore since a year or 2, but I remember this being useful for me, so I'd say that yes, this was & probably is still a welcome change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically, references don't seem to work when using yarn berry (might also not work with other PnP implementations)
But using the "types" field in the package.json makes things work, so this PR includes a package.json in all folder so they can be included without references (see the tsconfig.json in the example below)