refactor: optimize toggleSidebar trigger conditions#2557
refactor: optimize toggleSidebar trigger conditions#2557sy-records merged 1 commit intodocsifyjs:developfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi @sy-records , thanks so much for looking into this! Your fix looks really good, but before proceeding I thought I'd share two of those original demos updated with your preview build to confirm that everyone is on-board re: updated behaviour. Here is the updated codebox (using your new build), tap on the second page topic and sidebar now closes on mobile: Here is an the updated Docsify v5 rc-1 example using your new build - tap on Topic One and Topic two when on mobile and now the sidebar closes as expected: Thanks again, rc-1 is really coming along 🚀 |
|
I've done more tests and this continues to look solid, I'll add my review now. I've also updated my test Docsify-This v2 build to use your updated Sidebar docsify.min.js for continued testing, and you can try it out at https://preview-v2.docsify-this.net/?basePath=https://raw.githubusercontent.com/hibbitts-design/docsify-this-multiple-page-open-publishing-site/main&homepage=home.md&sidebar=true&loadSidebar=_sidebar.md&docsify-core-theme=true#/ |
Summary
When there is no sub sidebar, the sidebar should be closed.
Related issue, if any:
Close #2556
What kind of change does this PR introduce?
Refactor
For any code change,
Does this PR introduce a breaking change?
No
Tested in the following browsers: