Fix add/remove_index detail in README#153
Open
henrahmagix wants to merge 1 commit intodoctolib:masterfrom
Open
Fix add/remove_index detail in README#153henrahmagix wants to merge 1 commit intodoctolib:masterfrom
henrahmagix wants to merge 1 commit intodoctolib:masterfrom
Conversation
Both `add_index` and `remove_index` use `without_timeout(&)`, so they don't set a lock timeout of 30 seconds =) See https://github.com/doctolib/safe-pg-migrations/blob/b0efa6d52d304f22eb9fdba5e94448c3bde00467/lib/safe-pg-migrations/plugins/statement_insurer.rb#L64 and https://github.com/doctolib/safe-pg-migrations/blob/b0efa6d52d304f22eb9fdba5e94448c3bde00467/lib/safe-pg-migrations/plugins/statement_insurer.rb#L71
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both
add_indexandremove_indexusewithout_timeout(&), so they don't set a lock timeout of 30 seconds =)See
safe-pg-migrations/lib/safe-pg-migrations/plugins/statement_insurer.rb
Line 64 in b0efa6d
safe-pg-migrations/lib/safe-pg-migrations/plugins/statement_insurer.rb
Line 71 in b0efa6d