Open
Conversation
Implement unique task IDs for all tasks spawned via TaskManager to improve debugging and visibility during development. Key changes: - Add TaskId type with unique sequential ID generation using atomic counter - Track which task initiated graceful shutdown via shutdown_initiator field - Include task IDs in all logging statements (completion, panic, etc.) - Add TaskManager::shutdown_initiator() to query shutdown initiator - Add TaskBuilder::id() to retrieve task ID before spawning - Update tests to verify shutdown initiator tracking This helps identify which task caused the manager to shut down, making debugging easier during development. Closes DOJ-1071 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #294 +/- ##
==========================================
+ Coverage 73.32% 75.58% +2.26%
==========================================
Files 209 230 +21
Lines 23132 27276 +4144
==========================================
+ Hits 16961 20617 +3656
- Misses 6171 6659 +488 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e3bd68b to
e897bbb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements unique task IDs for all tasks spawned via
TaskManagerto improve debugging and visibility during development.Changes
TaskId Type: Added a new
TaskIdtype that uniquely identifies each spawned taskDisplay,Debug,Clone,Copy,PartialEq,Eq, andHashShutdown Initiator Tracking: Tasks that trigger graceful shutdown are now tracked
shutdown_initiatorfield to store the ID of the task that initiated shutdownTaskManager::shutdown_initiator()returns the initiator task IDEnhanced Logging: All task completion and panic messages now include task IDs
infolevel with ID and namedebuglevel with ID and nameid = <task_id>, task = <optional_name>TaskBuilder Integration: Each
TaskBuildergets a unique ID when createdTaskBuilder::id()method to retrieve the task's ID before spawningbuild_task()Benefits
Usage Example
Testing
Closes DOJ-1071
🤖 Generated with Claude Code