Conversation
Member
Author
|
at commit serde broke the private api in serde-rs/serde#2980. solved in |
blockifier to v0.16.0-rc.0
e3bd68b to
e897bbb
Compare
68cbbac to
c0d49bb
Compare
Member
Author
|
starknet-io/types-rs#155 breaks the serialization format for |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #392 +/- ##
==========================================
- Coverage 73.32% 72.74% -0.59%
==========================================
Files 209 248 +39
Lines 23132 29645 +6513
==========================================
+ Hits 16961 21564 +4603
- Misses 6171 8081 +1910 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #393, #388, #198, #209, #211, #256, #268.
When running
cargo vendor, we're stuck with this error:The dependencies bump is required because we are removing the
starknetcrate patch:The initial reason for the patch is for this PR xJonathanLEI/starknet-rs#773 but it's no longer needed since #256.
The dependency updates were originally meant to only make the project compile after removing the patch. Given the tight integration with
blockifierand the breaking database format change introduced inv0.16.0-rc.0, this PR is now primarily about updatingblockifier, with patch removal as a side effect.Database Backward Compatibility
TransactionExecutionInfo
blockifierv0.16.0-rc.0 has a breaking change in theTransactionExecutionInfostruct. In order to maintain backward-compatibility, if database can't deserialize theTransactionExecutionInfoit'd simply return nothing instead of failing.This is still temporary for now and may change once we find a better solution that doesn't require dropping old data.
Felt Serialization
The
starknet-types-corecrate has a breaking change inFeltserialization (see starknet-io/types-rs#155). To maintain backward compatibility with existing databases, aFelt32wrapper type is used to ensureFeltvalues are always serialized as 32-byte big-endian arrays when stored in the database.The reason to vendor the Cargo dependencies is to make the Katana binary build hermetic in order to achieve reproducible build process.