Open
Conversation
The rust_embed macro requires the explorer UI dist folder to exist at compile time. On macOS, unlike Ubuntu which uses a dev container with the explorer pre-built, we need to explicitly build it. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The download-artifact action downloads files to the current directory by default, not preserving the original path structure. Added explicit path parameter to download binary to target/debug/ directory. Also fixed GITHUB_PATH usage to use proper append syntax. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Tests compile with --all-features which includes the explorer crate. The explorer requires ui/dist to exist for the RustEmbed macro. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The katana-grpc crate requires protoc for compiling proto files. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #398 +/- ##
==========================================
- Coverage 73.32% 72.59% -0.73%
==========================================
Files 209 253 +44
Lines 23132 29811 +6679
==========================================
+ Hits 16961 21641 +4680
- Misses 6171 8170 +1999 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
macOS runners are slower than Ubuntu with 32 cores, and building with code coverage requires full compilation. 30 minutes was not enough. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Code coverage with llvm-cov requires full instrumented recompilation which takes over 60 minutes on macOS runners. Run coverage only on Ubuntu (32 cores) and run regular tests on macOS. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
macOS still requires a full build even without coverage instrumentation. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the test workflow to run on both Ubuntu and macOS.