feat(table-of-contents): cached data#3319
Open
Alexnortung wants to merge 6 commits intodolanmiu:masterfrom
Open
feat(table-of-contents): cached data#3319Alexnortung wants to merge 6 commits intodolanmiu:masterfrom
Alexnortung wants to merge 6 commits intodolanmiu:masterfrom
Conversation
Alexnortung
force-pushed
the
feat/toc-cached
branch
from
99a9a5a to
fb7c0ba
Compare
Alexnortung
force-pushed
the
feat/toc-cached
branch
3 times, most recently
from
1e6c09f to
7bb778c
Compare
Alexnortung
force-pushed
the
feat/toc-cached
branch
from
7bb778c to
f5668e6
Compare
Alexnortung
force-pushed
the
feat/toc-cached
branch
from
f5668e6 to
22876f9
Compare
Contributor
Author
|
For some reason, the level margin doesn't work as expected, not sure why |
This commit can be squashed with the previous one if necessary
Alexnortung
force-pushed
the
feat/toc-cached
branch
from
6ebc5e7 to
09fb2d0
Compare
Contributor
Author
|
I am not sure why test is failing. I am pretty sure I am covering all code paths in the code that I have added. Also what is wrong with the CSpell? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is a draft as I would like some feedback for the direction.
I think it would be beneficial to be able to provide cached data for the table of contents, just like other fields.
Does the
ToCEntrytype make sense, should it be defined elsewhere? Or should it be something else entirely?Does other properties also influence the output?
TODO: