[11.0 P1] Forms on Blazor support DisplayName attribute#36438
[11.0 P1] Forms on Blazor support DisplayName attribute#36438ilonatommy wants to merge 7 commits intomainfrom
DisplayName attribute#36438Conversation
guardrex
left a comment
There was a problem hiding this comment.
Thanks @ilonatommy ... Approving with tiny NITs.
I'll take care of the release notes. I'll ping you on that PR when it goes up within the next few days.
Co-authored-by: Luke Latham <1622880+guardrex@users.noreply.github.com>
Co-authored-by: Luke Latham <1622880+guardrex@users.noreply.github.com>
|
@ilonatommy I've opened a new pull request, #36445, to work on those changes. Once the pull request is ready, I'll request review from you. |
guardrex
left a comment
There was a problem hiding this comment.
Approve with just one NIT on a colon.
LGTM ... and I'll have the release notes for this and the startup options format up on GH shortly ... will ping u for review.
Co-authored-by: Luke Latham <1622880+guardrex@users.noreply.github.com>
Co-authored-by: Luke Latham <1622880+guardrex@users.noreply.github.com>
DisplayName attributeDisplayName attribute
|
@guardrex, we will have dotnet/aspnetcore#64821 update to this feature soon. Do you want me to update this PR or to create a new PR? |
|
|
|
Oh ... I see ... it's really a new feature. In that case, I recommend a new PR. I'll take care of the What's New updates separately. |
ups, I did not see this before pushing 😭 Is it okay to leave it as it is? |
|
Yes, indeed! Whatever is easiest for you. |
Doc changes proposal for dotnet/aspnetcore#64636.
Issue: dotnet/aspnetcore#49147
Internal previews