Merged
Conversation
roji
approved these changes
Jan 8, 2025
Member
roji
left a comment
roji
left a comment
There was a problem hiding this comment.
Thanks @ErikEJ, LGTM.
... although :) Doesn't SqlClient map string to nvarchar(max) and DateTime to datetime2(7) etc.?
The EF provider could still decide to do something else and set Size/Precision/Scale on the parameters it sends - so I think your fix is still right. But it makes @BrentOzar's argument a bit weaker.
Contributor
Author
|
@roji SqlClient maybe, but not "SQL Server" - dont think it does any "mapping" |
Member
|
Yep. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@BrentOzar FYI
https://www.brentozar.com/archive/2025/01/i-feel-sorry-for-untrained-developers-using-entity-framework/