-
-
Notifications
You must be signed in to change notification settings - Fork 444
[3.0] Improve handling of Khronos enum native names #2534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Exanite
merged 11 commits into
dotnet:develop/3.0
from
Exanite:fix/incorrect-native-name-glenum
Jan 30, 2026
Merged
[3.0] Improve handling of Khronos enum native names #2534
Exanite
merged 11 commits into
dotnet:develop/3.0
from
Exanite:fix/incorrect-native-name-glenum
Jan 30, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…name for certain Vulkan enums
Exanite
commented
Jan 12, 2026
Member
Author
Exanite
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Self review complete. Marking as ready for review and subsequent merge.
Perksey
reviewed
Jan 12, 2026
7 tasks
Member
Author
|
This PR will be ready for review/merge once Exanite#30 is merged into this PR. |
…-enums [3.0] Fix missings [Flags] attribute on certain OpenGL enums; Require explicit typemap for enum base types
curin
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
This changes the native name for namespaced enums like
GLEnumto beGLenum.In the process, I also found a bug where Vulkan enums had inconsistent native names.
Related issues, Discord discussions, or proposals
Discord conversation: https://discord.com/channels/521092042781229087/587346162802229298/1460042806952198310
PR where this issue was first discovered: #2503
This PR contains the following sub-PR:
Further Comments
N/A