Fix View Indexes not Scaffolded in Sql Server

[sarbas33]

• I've read the guidelines for contributing and seen the walkthrough
• I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
• The code builds and tests pass locally (also verified by our automated build checks)
• Commit messages follow this format:

        Summary of the changes
        - Detail 1
        - Detail 2

        Fixes #bugnumber

• Tests for the changes have been added (for bug fixes / features)
• Code follows the same patterns and style as existing code in this repo

Summary of the changes

• This PR adds a fix so that view indexes in SQL Server are correctly included when scaffolding a database schema.
• A CTE was required here since the column temporal_type was not present either in sys.views or sys.object, and the column was required to be present since it was part of the table filter.

Fixes #37345

[AndriySvyryd]

@sarbas33 Please file an issue to track what is being fixed

[sarbas33]

@AndriySvyryd . This PR fixes #37345.

[ErikEJ]

@sarbas33 Why is scaffolding of indexes important?

Have you tested the performance of the updated query (compared with the current one) against a sizeable database?

[sarbas33]

@ErikEJ Scaffolding indexes on views may be required only for correctness of metadata.

Regarding performance, I tested on database with 10000 tables and 1000 views, new query introduces a small one-time compile cost (~150ms) due to the CTE, but execution time is comparable or slightly improved. Since this runs only during scaffolding, the performance impact can be considered negligible.

[AndriySvyryd]

Thanks for your contribution!

[ErikEJ]

@AndriySvyryd Why was this merged into the release branch?