Skip to content

Conversation

@rolfbjarne
Copy link
Member

When we're dealing with an app that runs on both iPhone and iPad, we need to
list both iPhone and iPad simulators, not just iPad simulators.

This fixes an issue where we'd fail to find a simulator when specified by a udid if:

  • The app targets both iPhone and iPad.
  • The desired simulator is an iPhone.

The symptom would be this error, after 'dotnet run':

error MT1207: Could not find the simulator device type 'iPhone 4s'.

Backport of #24610.

…ents task.

When we're dealing with an app that runs on both iPhone and iPad, we need to
list both iPhone and iPad simulators, not just iPad simulators.

This fixes an issue where we'd fail to find a simulator when specified by a udid if:

* The app targets both iPhone and iPad.
* The desired simulator is an iPhone.

The symptom would be this error, after 'dotnet run':

> error MT1207: Could not find the simulator device type 'iPhone 4s'.
@rolfbjarne rolfbjarne requested a review from Copilot February 2, 2026 20:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug in the GetMlaunchArguments MSBuild task where simulator device lookup failed for apps targeting both iPhone and iPad when the specified simulator was an iPhone. The fix ensures that both iPhone and iPad simulators are queried when the app supports both device types.

Changes:

  • Modified the device type lookup logic to support multiple product families instead of a single family
  • Updated the XPath query to search for simulators matching any of the applicable product families

@dalexsoto
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@rolfbjarne rolfbjarne enabled auto-merge (squash) February 3, 2026 15:34
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #b4b5760] Build passed (Build packages) ✅

Pipeline on Agent
Hash: b4b576070464c1e034b79f2332ea28f6c7256d99 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #b4b5760] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: b4b576070464c1e034b79f2332ea28f6c7256d99 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: b4b576070464c1e034b79f2332ea28f6c7256d99 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #b4b5760] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: b4b576070464c1e034b79f2332ea28f6c7256d99 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #b4b5760] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: b4b576070464c1e034b79f2332ea28f6c7256d99 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #b4b5760] Tests on macOS X64 - Mac Sonoma (14) passed 💻

All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: b4b576070464c1e034b79f2332ea28f6c7256d99 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #b4b5760] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: b4b576070464c1e034b79f2332ea28f6c7256d99 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [CI Build #b4b5760] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 1 tests failed, 134 tests passed.

Failures

❌ monotouch tests (iOS) [attempt 2]

1 tests failed, 8 tests passed.

Failed tests

  • monotouch-test/iOS - simulator/Release (interpreter): Crashed

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 9 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 17 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 13 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: b4b576070464c1e034b79f2332ea28f6c7256d99 [PR build]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants