-
Notifications
You must be signed in to change notification settings - Fork 555
[release/11.0.1xx-preview1] [msbuild] Fix finding applicable simulator devices in GetMlaunchArguments task. #24611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/11.0.1xx-preview1
Are you sure you want to change the base?
Conversation
…ents task. When we're dealing with an app that runs on both iPhone and iPad, we need to list both iPhone and iPad simulators, not just iPad simulators. This fixes an issue where we'd fail to find a simulator when specified by a udid if: * The app targets both iPhone and iPad. * The desired simulator is an iPhone. The symptom would be this error, after 'dotnet run': > error MT1207: Could not find the simulator device type 'iPhone 4s'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a bug in the GetMlaunchArguments MSBuild task where simulator device lookup failed for apps targeting both iPhone and iPad when the specified simulator was an iPhone. The fix ensures that both iPhone and iPad simulators are queried when the app supports both device types.
Changes:
- Modified the device type lookup logic to support multiple product families instead of a single family
- Updated the XPath query to search for simulators matching any of the applicable product families
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…610-release/11.0.1xx-preview1-2026-02-02
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #b4b5760] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #b4b5760] Build passed (Detect API changes) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #b4b5760] Build passed (Build macOS tests) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💻 [CI Build #b4b5760] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
💻 [CI Build #b4b5760] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #b4b5760] Tests on macOS arm64 - Mac Tahoe (26) passed 💻✅ All tests on macOS arm64 - Mac Tahoe (26) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🔥 [CI Build #b4b5760] Test results 🔥Test results❌ Tests failed on VSTS: test results 0 tests crashed, 1 tests failed, 134 tests passed. Failures❌ monotouch tests (iOS) [attempt 2]1 tests failed, 8 tests passed.Failed tests
Html Report (VSDrops) Download Successes✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
When we're dealing with an app that runs on both iPhone and iPad, we need to
list both iPhone and iPad simulators, not just iPad simulators.
This fixes an issue where we'd fail to find a simulator when specified by a udid if:
The symptom would be this error, after 'dotnet run':
Backport of #24610.