Fixed serialization of the HighDpiMode value#9629
Merged
drewnoakes merged 1 commit intomainfrom Jan 15, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ADO#2300157
Context
@drewnoakes fixed a typo in the name of the element used for HighDpiMode serialization, so the deserializer now picks up that value. However, there is a type mismatch. The value is serialized as a boolean, but the deserializer converts it to an Int32. The exception thrown by this failed conversion causes problems when editing VB WinForms project properties in Visual Studio.
Fix
The value is now serialized as Int32.
Microsoft Reviewers: Open in CodeFlow