Use AppliesTo Attribute Only for LaunchSettings-Specific Query Providers#9641
Merged
drewnoakes merged 4 commits intodotnet:mainfrom Feb 3, 2025
Merged
Conversation
emfisch
changed the title
drewnoakes
reviewed
Jan 31, 2025
Member
drewnoakes
left a comment
drewnoakes
left a comment
There was a problem hiding this comment.
Looks good, though one question around capabilities.
...rojectSystem.Managed.VS/ProjectSystem/VS/Query/LaunchProfiles/LaunchProfileActionProvider.cs
Show resolved
Hide resolved
...tudio.ProjectSystem.Managed.VS/ProjectSystem/VS/Query/PropertyPages/ProjectActionProvider.cs
Show resolved
Hide resolved
drewnoakes
approved these changes
Feb 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to these PRs: #9621, #9631
The TypeScript/JavaScript team is working on adding a version of the launch profiles UI that reads/writes from
launch.jsonrather thanlaunchsettings.json. We'd like reuse dotnet's existing functionality for this, with the exception of actions specific to modifyinglaunchsettings.json. With this PR, all actions specific tolaunchsettings.jsonhave been moved into a separate class (LaunchProfileProjectActionProvider) with relevant filtering([AppliesTo(ProjectCapability.DotNet)]). I have removed this filtering from the other action providers so they can be used for JSPS projects as well.Microsoft Reviewers: Open in CodeFlow