Fix cursor editor icon width calculation for proper DPI scaling#14168
Open
Fix cursor editor icon width calculation for proper DPI scaling#14168
Conversation
Co-authored-by: SimonZhao888 <133954995+SimonZhao888@users.noreply.github.com>
…stency Co-authored-by: SimonZhao888 <133954995+SimonZhao888@users.noreply.github.com>
Co-authored-by: SimonZhao888 <133954995+SimonZhao888@users.noreply.github.com>
Co-authored-by: SimonZhao888 <133954995+SimonZhao888@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix cursor editor display issues in propertyGrid for HDPI settings
Fix cursor editor ItemHeight calculation for proper DPI scaling
Dec 24, 2025
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #14168 +/- ##
===================================================
- Coverage 77.15877% 77.15187% -0.00691%
===================================================
Files 3279 3279
Lines 645333 645335 +2
Branches 47720 47720
===================================================
- Hits 497931 497888 -43
- Misses 143719 143749 +30
- Partials 3683 3698 +15
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Member
LeafShi1
reviewed
Jan 8, 2026
src/System.Windows.Forms.Design/src/System/Drawing/Design/CursorEditor.CursorUI.cs
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a DPI scaling issue in the cursor editor where certain cursors (HSplit, VSplit) appeared wider than others at specific DPI settings (125%, 175%, 225%, 250%), causing display alignment issues in the PropertyGrid. The fix standardizes icon width by calculating it once using the default cursor as a reference, rather than computing individual widths for each cursor during drawing.
Key changes:
- Introduces a
_cursorWidthfield calculated once in the constructor usingCursors.Default - Refactors
OnDrawItemto use the pre-calculated width instead of computing it per cursor - Improves performance by eliminating repeated DPI scaling calculations during drawing
src/System.Windows.Forms.Design/src/System/Drawing/Design/CursorEditor.CursorUI.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Drawing/Design/CursorEditor.CursorUI.cs
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Drawing/Design/CursorEditor.CursorUI.cs
Show resolved
Hide resolved
LeafShi1
approved these changes
Jan 9, 2026
ricardobossan
approved these changes
Jan 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes #14167
Root Cause
Icons similar to HSplit.cur, VSplit.cur are wider than other icons at certain DPI settings (such as 125%, 175%, 225%, 250%), which is causing the webtable to display abnormally.
Proposed changes
Customer Impact
Regression?
Risk
Screenshots
Before
After
150DPI:
150DPI.mp4
175DPI:
175DPI.mp4
200DPI:
200DPI.mp4
225DPI:
225DPI.mp4
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow