Open
Conversation
funkyshu
requested changes
Dec 14, 2023
Collaborator
funkyshu
left a comment
funkyshu
left a comment
There was a problem hiding this comment.
Can you provide updates to the docs near:
goqu/select_dataset_example_test.go
Line 952 in 594a433
and example near:
goqu/select_dataset_example_test.go
Line 952 in 594a433
| return sd.joinTable(exp.NewUnConditionedJoinExpression(exp.CrossJoinType, table)) | ||
| } | ||
|
|
||
| // Adds a CROSS JOIN clause. See examples. |
Collaborator
There was a problem hiding this comment.
This is not a a CROSS JOIN.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i've added support for this
https://clickhouse.com/docs/en/sql-reference/statements/select/array-join
May be it should be added to some dialect explicitly, because ClickHouse has a lot of custom sql syntax and features. But implementing flexible analytical query builder i lacked really only Array Join operator