Customizable useSelect input debounce wait#1533
Open
tpict wants to merge 1 commit intodownshift-js:masterfrom
Open
Customizable useSelect input debounce wait#1533tpict wants to merge 1 commit intodownshift-js:masterfrom
tpict wants to merge 1 commit intodownshift-js:masterfrom
Conversation
Collaborator
|
Hi @tpict ! I can understand the need for having a custom value option instead of the hardcoded Can you describe the use case better, please? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: The hard-coded 500ms wait until
useSelect's input is cleared is being changed to a customizable prop.Why: So this behavior can be customized or opted out of.
How: Replaced the hard-coded number with a prop. If the customized value is below zero, the value won't be cleared at all.
Checklist:
Let me know what you think, and I can write docs etc if needed 🙂