fix(type): item in isItemDisabled may be undefined (fixes #1623)#1631
Open
KrzysztofKarol wants to merge 1 commit intodownshift-js:masterfrom
Open
fix(type): item in isItemDisabled may be undefined (fixes #1623)#1631KrzysztofKarol wants to merge 1 commit intodownshift-js:masterfrom
KrzysztofKarol wants to merge 1 commit intodownshift-js:masterfrom
Conversation
Author
|
Is there anything I can do to help? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Typings changed. Item in
isItemDisabledmay be undefined, e. g.downshift/src/hooks/utils.js
Line 659 in 59d3498
Why:
Developers should handle this case to avoid runtime errors.
How:
Only typings changed.
Checklist:
Fixes #1623
Offtopic
Probably types of others methods should be check and fixed
e.g.
because
downshift/src/hooks/utils.js
Line 609 in 59d3498