update selection state machine #1756
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of the issue
The existing behavior of clicking an already picked card leading to the selection being confirmed, rather than removing the pick was confusing to my pod. The card click was managing two things:
A simpler solution was to allow the card click to exclusively manage the card state, and the confirmation button exclusively manage the pack confirmation state. Separation of concerns and all that.
Description of your changes
Screenshots