Skip to content

Conversation

@edward-coombes
Copy link

Explanation of the issue

The existing behavior of clicking an already picked card leading to the selection being confirmed, rather than removing the pick was confusing to my pod. The card click was managing two things:

  1. The card's pick/burn state
  2. The pack's confirmation state

A simpler solution was to allow the card click to exclusively manage the card state, and the confirmation button exclusively manage the pack confirmation state. Separation of concerns and all that.

Description of your changes

  • Clicking on an already picked card will remove the pick/burn, and not confirm the selection.
  • Clicking
  • Clicking on a card when the burn/pick limit is already reached will have no effect
    • note: I wasn't sure if this was the best choice, the other option is to allow the picks to go over the limit, but this felt confusing as well, requiring you to count the cards picked and refer to the pick count. I'm happy to revert / change this if you'd like.

Screenshots

Screenshot 2026-01-09 at 4 15 17 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant