fix: Optimize the logic for preventing scrolling events#5520
Open
wubocao wants to merge 2 commits intodream-num:devfrom
Open
fix: Optimize the logic for preventing scrolling events#5520wubocao wants to merge 2 commits intodream-num:devfrom
wubocao wants to merge 2 commits intodream-num:devfrom
Conversation
View Deployment
|
wubocao
changed the title
Member
|
Why not disable wheel or similar events for mounted DOM elements 🤔 https://stackblitz.com/edit/univer-sheets-vite-bw8uha1g?file=src%2Fmain.ts |
Contributor
Author
I hope its behavior is consistent with the container embedded in the page that has a scroll bar. When the internal container scrolls to the boundary, it should trigger the scrolling of the page. It is not possible to simply prevent the scrolling event. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix:
When the worksheet is embedded in an HTML page with scrollbars:
1 - When the worksheet has no scrollbars, scrolling the mouse within the worksheet prevents the scrolling of the HTML page.
2 - Optimize the interaction experience when the worksheet has both X and Y scrollbars and one of them reaches the bottom boundary.
Pull Request Checklist
2025-07-11.19.10.07.mov