fix(drizzle-zod): apply ZodOptional for insert schema refinements on nullable/default columns#5209
Open
swalha1999 wants to merge 1 commit intodrizzle-team:mainfrom
Conversation
…nullable/default columns When using function refinements in createInsertSchema, the type inference was not correctly applying ZodOptional for: - Nullable columns (should be optional since they can be omitted) - NotNull columns with defaults (should be optional since defaults will be used) This caused a type mismatch where the inferred type was `string | null` but the runtime schema was `string | null | undefined`. The fix aligns HandleRefinement with HandleInsertColumn logic: - For nullable columns: z.ZodOptional<z.ZodNullable<TSchema>> - For notNull with default: z.ZodOptional<TSchema> - For notNull without default: TSchema (required)
Author
|
is there any update on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using function refinements in
createInsertSchema, the type inference was not correctly applyingZodOptionalfor:This caused a type mismatch where the inferred type was
string | nullbut the runtime schema correctly producedstring | null | undefined.Example
Solution
The fix aligns
HandleRefinementtype withHandleInsertColumnlogic:z.ZodOptional<z.ZodNullable<TSchema>>z.ZodOptional<TSchema>TSchema(required)Changes
HandleRefinementtype indrizzle-zod/src/schema.types.internal.tsTesting
All 70 existing drizzle-zod tests pass.