fix(skills): align dev skill source discovery with stable Homebrew layout#61
Conversation
Deploying sciclaw with
|
| Latest commit: |
d5c6bec
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5138c4ed.sciclaw.pages.dev |
| Branch Preview URL: | https://fix-dev-skill-source-alignme.sciclaw.pages.dev |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d5c6bec9b5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| func skillsInstallBuiltinCmd(workspace string) { | ||
| builtinSkillsDir := "./picoclaw/skills" | ||
| builtinSkillsDir := resolveBuiltinSkillsDir(workspace) |
There was a problem hiding this comment.
skillsInstallBuiltinCmd now trusts resolveBuiltinSkillsDir(workspace), which currently scans baselineSkillSourceDirs where <cwd>/skills is the highest-priority candidate; when the command is run from the workspace root, this resolves to the same workspace/skills tree being written. In that case copyDirectory(builtinPath, workspacePath) is invoked with identical source/destination, and copyDirectory opens destination files with O_TRUNC, so existing SKILL.md content can be truncated during the self-copy. Please ensure builtin resolution excludes workspace/cwd skill directories (or guard against src == dst) before copying.
Useful? React with 👍 / 👎.
1 participant
Summary:\n- align builtin skill source discovery with stable and dev Homebrew layouts\n- resolve builtin skills directory from executable share paths\n- update install-builtin and list-builtin to use the same resolver\n- add tests for stable and dev formula paths\n\nValidation:\n- go test ./cmd/picoclaw\n- reproduced current dev bug on data1\n- verified patched binary installs all 15 baseline skills