feat(workspace): add shared workspace policy with read-only guardrails#62
feat(workspace): add shared workspace policy with read-only guardrails#62drpedapati merged 1 commit intomainfrom
Conversation
Deploying sciclaw with
|
| Latest commit: |
ff88726
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://545aa542.sciclaw.pages.dev |
| Branch Preview URL: | https://feat-shared-workspace-policy.sciclaw.pages.dev |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ff8872629d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| cwdInSharedRoot := sharedRoot != "" && isWithinWorkspace(cwdPath, sharedRoot) | ||
| if cwdInSharedRoot && t.sharedWorkspaceReadOnly && looksMutatingCommand(cmd) { | ||
| return "Command blocked by safety guard (shared workspace is read-only)" |
There was a problem hiding this comment.
This check blocks any mutating shell command whenever cwd is inside sharedWorkspace, without first confirming that the command targets the shared read-only area rather than the writable active workspace. With the new defaults (workspace and shared_workspace both ~/sciclaw) and common routed setups where workspaces are nested under that root, commands like touch file.txt or git apply in the agent’s own workspace are now rejected, which is a regression and also inconsistent with the file tools’ path policy behavior.
Useful? React with 👍 / 👎.
1 participant
Summary\n- add shared workspace config defaults and path resolver\n- thread shared workspace policy into agent tool wiring\n- allow reads from shared workspace while enforcing read-only writes when configured\n- extend filesystem/shell/edit/message/word-count/pubmed-export tools with shared policy checks\n- update context fallback to prefer shared workspace skill paths\n- add tests for shared workspace read/write guard behavior\n\n## Validation\n- go test ./pkg/config ./pkg/agent ./pkg/tools\n- go test ./... (fails only in existing pkg/channels allowlist tests, unrelated)\n