Variation title generate event#707
Open
ReplicaObscura wants to merge 5 commits intodrupalcommerce:8.x-2.xfrom
Open
Variation title generate event#707ReplicaObscura wants to merge 5 commits intodrupalcommerce:8.x-2.xfrom
ReplicaObscura wants to merge 5 commits intodrupalcommerce:8.x-2.xfrom
Conversation
Latest changes from commerce
Upstream updates
mglaman
requested changes
Apr 4, 2017
Contributor
mglaman
left a comment
mglaman
left a comment
There was a problem hiding this comment.
Can we add a test module, like commerce_product_test even, which subscribes to this event. If the product's SKU is GENERATE_TEST (or something) it'll react and change the title. So we can prove it works and document the feature via tests.
bojanz
force-pushed
the
8.x-2.x
branch
7 times, most recently
from
6be1d5c to
b8a7444
Compare
Contributor
Author
|
I'll work on these tests ASAP btw, sorry for leaving this out there for so long. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry for the stray merge commits, there are no changes from those merges represented here.
This is an attempt to resolve https://www.drupal.org/node/2846895 by adding a new event that's dispatched after generating the variation title, before saving it to the variation.