Add separate render function to CheckoutProgressBlock#869
Open
MatthieuScarset wants to merge 3 commits intodrupalcommerce:8.x-2.xfrom
MatthieuScarset:extends-checkout-progress-block
Open
Add separate render function to CheckoutProgressBlock#869MatthieuScarset wants to merge 3 commits intodrupalcommerce:8.x-2.xfrom MatthieuScarset:extends-checkout-progress-block
MatthieuScarset wants to merge 3 commits intodrupalcommerce:8.x-2.xfrom
MatthieuScarset:extends-checkout-progress-block
Conversation
Useful for children plugins to display this Block on other routes than Checkout pages
Useful for children plugins to display this Block on other routes than Checkout pages
…Scarset/commerce into extends-checkout-progress-block
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem/Motivation
As a site builder, I would like to display the
CheckoutProgressBlockon the Cart page (e.g/cart).As of today, I can not do so. This block is restricted to
checkoutpages, where thecommerce_productparameter is available.Proposed solution
To separate the rendering of the
CheckoutProgressBlockin another function. Currenlty, everything is inside thebuild()method.This way, as a developer, I can create a child block and render the
CheckoutProgressBlockwith my own logic.Example
Here is an example of a child block which load the current Cart if the default
CheckoutProgressBlockrendered nothing.https://gist.github.com/MatthieuScarset/c29672ee99805d955988bc150bb642ab