Open
Conversation
Added fix for issue dsccommunity#176 , DNS Delegation not included in ADDomain. And incorporated fix from ansible/ansible#39235
Contributor
|
@nanderh, thanks for your contribution and raising this PR. The CI checks are currently failing for it, as you need to update the changelog, and modify the |
|
Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added fix for issue #176 , DNS Delegation not included in ADDomain. And incorporated fix from ansible/ansible#39235
Pull Request (PR) description
Added fix for above issues by:
DnsDelegationCredentialoption has been usednetlogonservice after domain installationThis Pull Request (PR) fixes the following issues
Fixes issue #176 ADDomain: DNS Delegation is no longer working.
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
and comment-based help.
This change is