Skip to content

RegistryPolicyFile: resolve issue #34 valuetype case mismatch in resource parser vs schema#35

Open
chambersmp wants to merge 5 commits intodsccommunity:masterfrom
chambersmp:issue_registrypolicyfile
Open

RegistryPolicyFile: resolve issue #34 valuetype case mismatch in resource parser vs schema#35
chambersmp wants to merge 5 commits intodsccommunity:masterfrom
chambersmp:issue_registrypolicyfile

Conversation

@chambersmp
Copy link

@chambersmp chambersmp commented Oct 24, 2023

Pull Request (PR) description

Resolve issue with GetRegTypeString() method returning unsupported values:
'DWord'
'QWord'

The resource schema file defines the expected values should be:
'Dword'
'Qword'

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Nov 3, 2023
@codecov
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 93%. Comparing base (db252f6) to head (1cc0e13).

Files with missing lines Patch % Lines
...ryPolicyFileParser/GPRegistryPolicyFileParser.psm1 50% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #35   +/-   ##
====================================
  Coverage      93%   93%           
====================================
  Files           3     3           
  Lines         357   357           
====================================
  Hits          334   334           
  Misses         23    23           
Files with missing lines Coverage Δ
...ryPolicyFileParser/GPRegistryPolicyFileParser.psm1 88% <50%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@johlju
Copy link
Member

johlju commented Nov 3, 2023

I think this should be resolved like I mentioned in the #34 (comment). What do you think?

@johlju johlju added waiting for author response The pull request is waiting for the author to respond to comments in the pull request. and removed needs review The pull request needs a code review. labels Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting for author response The pull request is waiting for the author to respond to comments in the pull request.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RegistryPolicyFile: registrypolicyfile parser returns unsupported valueType for dword and qword resources

2 participants