Add #remove on JsxElement and JsxSelfClosingElement#1371
Open
dherault wants to merge 4 commits intodsherret:latestfrom
Open
Add #remove on JsxElement and JsxSelfClosingElement#1371dherault wants to merge 4 commits intodsherret:latestfrom
dherault wants to merge 4 commits intodsherret:latestfrom
Conversation
dsherret
reviewed
Mar 16, 2023
| }); | ||
|
|
||
| it("should remove the JsxElement child", () => { | ||
| doTestWithJsxElementChild(`var t = (<jsx><jsx2></jsx2></jsx>);`, `var t = (<jsx></jsx>);`); |
Owner
There was a problem hiding this comment.
Thanks, but it's not so simple unfortunately. Once spaces are added then it gets much more complicated because spaces have meaning in JSX. It's why I haven't had the time to add this functionality yet. For example:
it("should remove the JsxElement child when has spaces", () => {
doTestWithJsxElementChild(
`var t = (<jsx>
<jsx2></jsx2>
</jsx>);`,
`var t = (<jsx></jsx>);`,
);
});
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for JsxElement.remove and JsxSelfClosingElement.remove
If anything just ask I'm around.