Conversation
Codecov Report
@@ Coverage Diff @@
## master #188 +/- ##
=========================================
Coverage ? 91.33%
=========================================
Files ? 19
Lines ? 2492
Branches ? 0
=========================================
Hits ? 2276
Misses ? 216
Partials ? 0Continue to review full report at Codecov.
|
|
awesome!!!! just tried a dataset that crashes my notebook when no partitioning is used, but that correctly solves when the optimization is incremental!!!!! |
|
great 😊,
i will convert you for loop into parallel one during the weekend
Maor
…________________________________
From: daniel servén <notifications@github.com>
Sent: Tuesday, July 24, 2018 12:56:40 PM
To: dswah/pyGAM
Cc: Subscribed
Subject: Re: [dswah/pyGAM] [WIP] big data GAM (#188)
awesome!!!! just tried a dataset that crashes my notebook when no partitioning is used, but that correctly solves when the optimization is incremental!!!!!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#188 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ASBgn3ToKBMHlrWCFpfXxI-UZ-UnUuSvks5uJu9YgaJpZM4VaF7t>.
|
|
hi,
i have changed the code now it should work in parallel,
i cannot push it into the branch, can you give me access ?
Regards,
MAor
…________________________________
From: Maor Nissan
Sent: Tuesday, July 24, 2018 1:36:02 PM
To: dswah/pyGAM; dswah/pyGAM
Cc: Subscribed
Subject: Re: [dswah/pyGAM] [WIP] big data GAM (#188)
great 😊,
i will convert you for loop into parallel one during the weekend
Maor
________________________________
From: daniel servén <notifications@github.com>
Sent: Tuesday, July 24, 2018 12:56:40 PM
To: dswah/pyGAM
Cc: Subscribed
Subject: Re: [dswah/pyGAM] [WIP] big data GAM (#188)
awesome!!!! just tried a dataset that crashes my notebook when no partitioning is used, but that correctly solves when the optimization is incremental!!!!!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#188 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ASBgn3ToKBMHlrWCFpfXxI-UZ-UnUuSvks5uJu9YgaJpZM4VaF7t>.
|
|
@maorn that is really cool! to contribute your code, please do the following:
Attention!!
looking forward to reading your code :) |
|
hi, |
|
hi @maorn!
|
adding parrallel for-loop
|
@mohsenzabihi @ccurro The plan is to merge this branch into master in August. But it needs a little love right now.
|
|
I know this PR is pretty old, but I'd still be really happy to see this functionality implemented. Figured I'd just mention it since it's been a couple of years since there's been any updates. |
fixes #187 #76
fixes #124
write an example like pomegranate out of core:
https://pomegranate.readthedocs.io/en/latest/ooc.html
QR updating
documentation
all methods avoid using full model matrix
statistics estimation work with new pirls
simplify statistics estimation
gamma is a instance argument
chunk size is instance arg
all models inherit new behavior
test with large dataset
write parallel version
ensure parallel version works in serial
do memory profiling. see if we can easily optimize memory anywhere
try parallelism
merge @maorn 'parallel' branch into this one
logic for skipping any parallelism if
n_cores==1joblib automatically does thisadd some tests for the new features
fix a couple of broken tests
figure out looping in partial_dependence...
get rid of matrix vs ndarray warnings
subsequent PR?
batch_sizeinstead ofblock_sizebatches_per_epochparameter andpartial_fitmethodmemory profile