Skip to content

PIR: Fix pixel definitions for a few pixels #7695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
landomen merged 3 commits into from
Feb 9, 2026
Merged

PIR: Fix pixel definitions for a few pixels #7695

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed2d4e7
Fix pixel schema
landomen Feb 6, 2026
9503984
Update product.json
landomen Feb 6, 2026
6b37776
Add daily_count_short to every PIR pixel
landomen Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions PixelDefinitions/pixels/personal_information_removal.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1004,7 +1004,7 @@
"description": "Fired when a scan or opt-out action fails while processing a data broker.",
"owners": ["karlenDimla", "landomen"],
"triggers": ["other"],
"suffixes": ["form_factor"],
"suffixes": ["daily_count_short", "form_factor"],
"parameters": [
"appVersion",
{
Expand Down Expand Up @@ -1044,7 +1044,7 @@
"description": "Android specific pixel which is fired when the PIR dashboard is opened",
"owners": ["karlenDimla", "landomen"],
"triggers": ["other"],
"suffixes": ["form_factor"],
"suffixes": ["daily_count_short", "form_factor"],
"parameters": ["appVersion"]
},
"m_dbp_initial_scan_duration": {
Expand Down Expand Up @@ -1457,7 +1457,7 @@
"description": "Android specific pixel which is fired when we detect that the secure storage is unavailable",
"owners": ["karlenDimla", "landomen"],
"triggers": ["other"],
"suffixes": ["form_factor"],
"suffixes": ["daily_count_short", "form_factor"],
"parameters": ["appVersion"]
},
"m_dbp_background-run_stats": {
Expand Down
2 changes: 1 addition & 1 deletion PixelDefinitions/product.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"agents": ["ddg_android"],
"target": {
"key": "appVersion",
"version": "5.262.0"
"version": "5.264.1"
},
"forceLowerCase": false
}
Loading