Draft
Conversation
Co-authored-by: jkingston <jkingston@duckduckgo.com>
|
Cursor Agent can help with this pull request. Just |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
👋 Don't forget to add an individual reviewer (in addition to those auto-added), as this will create a task for them in Asana.
👉 Please mark this as DRAFT unless there's an intention to merge this immediately. |
Generated file outputs:Time updated: Mon, 02 Feb 2026 13:18:58 GMT legacy29 files identical
latest14 files identical
|
JSON approval analysis:Time updated: Mon, 02 Feb 2026 13:29:03 GMT latest🎯 OVERALL APPROVAL STATUS✅ AUTO-APPROVED |
Co-authored-by: jkingston <jkingston@duckduckgo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asana Task/Github Issue:
Description
This PR updates the
feature-flag-cleanup-tracker.ymlworkflow to operate on the constructedgenerated/v*/android-config.jsonoutput rather than directly onoverrides/android-override.json.Key changes:
features/**/*.jsonin addition tooverrides/android-override.json.android-config.jsonfiles to detect new feature flags.features/andoverrides/) for cleanup.This change provides a more robust and accurate tracking of new feature flags by analyzing the final configuration consumed by clients, regardless of whether the change originated from an override or a feature definition.
Note
Medium Risk
Adds Node-based generation and dual checkouts to the workflow; failures or mismatched config versioning could prevent Asana cleanup tasks from being created even when flags are added.
Overview
Updates
feature-flag-cleanup-tracker.ymlto detect newly-added Android feature flags by comparing the generatedgenerated/v*/android-config.jsonoutput between the PR base and head commits instead of readingoverrides/android-override.jsondirectly.The workflow now also triggers on
features/**/*.json, checks out both base/head into separate directories, runsnpm ci+node index.jsto build configs, derives the config version fromCURRENT_CONFIG_VERSION, and updates Asana task text to reference the constructed file and instruct cleanup viafeatures/and/oroverrides/android-override.json.Written by Cursor Bugbot for commit ce97f42. This will update automatically on new commits. Configure here.