Jkt/auto/privacy configuration feature flags ca2a#4511
Draft
jonathanKingston wants to merge 10 commits intomainfrom
Draft
Jkt/auto/privacy configuration feature flags ca2a#4511jonathanKingston wants to merge 10 commits intomainfrom
jonathanKingston wants to merge 10 commits intomainfrom
Conversation
…clients Covers: - How remote config controls features (state, sub-features, rollouts, targets) - Why defaulting to false is the recommended practice - Per-client patterns: Apple (FeatureFlag enum), Android (@ContributesRemoteFeature), Windows (Feature/SubFeature enums), Extension, and C-S-S - Links to client-specific file locations and existing documentation - Cross-linked from existing config maintainer and feature implementer docs
- ST1: Split properties table into parent vs sub-feature; clarify that rollout/targets/cohorts are sub-feature-only; link to v6 config parity Asana task - ST2: Rewrite default value section as neutral 'Choosing a Default Value' with equal treatment of opt-in (false) and failsafe (true) patterns; link to Apple 'Using failsafe feature flags' doc - ST3: Expand Apple section with examples of all four properties (defaultValue, source, supportsLocalOverriding); remove 'matches the screenshot' note - ST4: Add strong warning against .remoteReleasable(.feature(...)) with explanation of why sub-features should be preferred (rollout/target/ cohort support, past incidents)
|
👋 Don't forget to add an individual reviewer (in addition to those auto-added), as this will create a task for them in Asana.
👉 Please mark this as DRAFT unless there's an intention to merge this immediately. |
Generated file outputs:Time updated: Thu, 12 Feb 2026 12:58:30 GMT legacy29 files identical
latest14 files identical
|
JSON approval analysis:Time updated: Thu, 12 Feb 2026 13:08:42 GMT latest🎯 OVERALL APPROVAL STATUS✅ AUTO-APPROVED |
Move detailed Swift code examples and warnings into a dedicated feature-flag-guide.md in the apple-browsers repo. This doc now links to it via GitHub URL so the repos remain independent.
Remove all client-side code examples and platform-specific terminology. Replace with a clean link table pointing to each client's own feature flag documentation. The guide now focuses purely on the remote config side: feature/sub-feature properties, choosing defaults, and best practices.
… table - Extension doesn't have a local flag enum; reword overview accordingly - Parent features do support minSupportedVersion; add to properties table
…verbosity Add warning about changing defaults on shipped features without minSupportedVersion. Remove text that restates config format (link to Implementation Guidelines instead). Use relative paths to features/ and overrides/. Move footguns to dedicated section.
…ig update, not failing to reach it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asana Task/Github Issue: https://app.asana.com/1/137249556945/task/1213208231266845
Description
Feature change process:
Site breakage mitigation process:
Brief explanation
Note
Low Risk
Documentation-only changes with no impact on runtime behavior or configuration generation.
Overview
Adds a new
docs/feature-flagging-guide.mdexplaining how privacy remote configuration feature states/sub-features map to client-side feature flags across Apple, Android, Windows, extensions, and content-scope scripts, including guidance on defaults and recommending sub-features for rollouts/targets/cohorts.Updates
docs/config-maintainer-documentation.mdanddocs/feature-implementer-documentation.mdto link to this new guide in their reference sections.Written by Cursor Bugbot for commit 79a3dde. This will update automatically on new commits. Configure here.