Set the job display name as just the class name#33
Open
cristiangrama wants to merge 1 commit intodusterio:masterfrom
Open
Set the job display name as just the class name#33cristiangrama wants to merge 1 commit intodusterio:masterfrom
cristiangrama wants to merge 1 commit intodusterio:masterfrom
Conversation
cristiangrama
force-pushed
the
fix-displayed-job-name
branch
5 times, most recently
from
6715092 to
ca5fdc4
Compare
Excludes the `@handle` that the `job` key has.
cristiangrama
force-pushed
the
fix-displayed-job-name
branch
from
ca5fdc4 to
6480751
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a job is created in Laravel it get's a display name as whatever the job class is. The
jobkey is the handler class with the suffix@handle. For example the classSomeJobwill be displayed asSomeJob@handle. In order to get the right job name for logging purposes it is better to just use the class name instead. Adding thedisplayNameto the created job payload will take care of that.