Skip to content

feat(install): honour configurable install root across components#739

Open
mister2d wants to merge 2 commits intodw-0:masterfrom
mister2d:master
Open

feat(install): honour configurable install root across components#739
mister2d wants to merge 2 commits intodw-0:masterfrom
mister2d:master

Conversation

@mister2d
Copy link

@mister2d mister2d commented Nov 5, 2025

  • fixed kiauh.sh from launching with an error stating top_border: command not found.

  • add install_root setting plus KIAUH_INSTALL_ROOT env override helper with legacy detection\n- route klipper, moonraker, extensions, and web clients to resolve paths via install root\n- create directories with sudo fallback and update backup/nginx helpers to use configured base\n- export actual backup destination in menu messaging and clarify default config.

  • Fix crowsnest install root propagation and atlas dependency detection

  • Ensure every crowsnest make invocation preserves the configured install root by injecting KIAUH_INSTALL_ROOT into the environment and using sudo --preserve-env, preventing installs from escaping the selected prefix. Also rerun make config/uninstall without relying on shell=True to avoid losing the environment.

  • Resolve the Debian Trixie input shaper install failure by dynamically selecting between libatlas3-base and libatlas-base-dev using installed package checks and apt-cache, so users get the available ATLAS variant while the prompts and dependency installer stay in sync.

HomelabIO added 2 commits October 13, 2025 16:13
- add install_root setting plus KIAUH_INSTALL_ROOT env override helper with legacy detection\n- route klipper, moonraker, extensions, and web clients to resolve paths via install root\n- create directories with sudo fallback and update backup/nginx helpers to use configured base\n- export actual backup destination in menu messaging and clarify default config
Ensure every crowsnest make invocation preserves the configured install root by injecting KIAUH_INSTALL_ROOT into the environment and using sudo --preserve-env, preventing installs from escaping the selected prefix. Also rerun make config/uninstall without relying on shell=True to avoid losing the environment.

Resolve the Debian Trixie input shaper install failure by dynamically selecting between libatlas3-base and libatlas-base-dev using installed package checks and apt-cache, so users get the available ATLAS variant while the prompts and dependency installer stay in sync.
@dw-0
Copy link
Owner

dw-0 commented Nov 9, 2025

Hi, thank you for your contribution.
Can you please split this PR to multiple ones, each one targeting one change at a time? This current PR seems to target 5 different situations. It is generally preferred to have scoped, incremental PRs instead of one big PR solving multiple things at once.

The first bullet point should also be already solved. I fixed that issue after receiving a bug report :)

@dw-0 dw-0 added the Feedback required Further information is required label Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feedback required Further information is required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants